On Thu, 2009-05-14 at 22:22 +1000, Neil Brown wrote: > On Thursday May 14, neilb@xxxxxxx wrote: > > > > Then the loop could be > > for (i = 0; i < conf->nr_strip_zones; i++) > > if (sector < conf->strip_zone[i+1]) > > return conf->strip_zone[i] > > > > Save our selves an 'add' that way :-) > > That should have been > > > > > Then the loop could be > > for (i = 0; i < conf->nr_strip_zones; i++) > > if (sector < conf->strip_zone[i+1]->zone_start) > > return conf->strip_zone[i] > > > > Save ourselves an 'add' that way :-) > > and as we aren't using ->sectors in this loop any more, I think it > can be discarded completely, just making struct strip_zone 20% smaller > and improving cache performance. > > What do you think? hamm.. please do not do it now. I think i need it for the reshape because I have to traverse each zone up to its end. > NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
