On Thu, May 14, 2009 at 2:41 AM, NeilBrown <neilb@xxxxxxx> wrote: > On Thu, May 14, 2009 3:08 am, SandeepKsinha wrote: >> Hi Neil, >> >> >> [22:33:46 sinhas]$ diff raid0.c raid0.c.orig > > Always, always, always use "diff -u". It provides context > so the diff is much easier to read. > >> 160d159 >> < zone->dev_start = 0; >> [/usr/src/linux-2.6.29/drivers/md] >> [22:33:59 sinhas]$ >> >> I see this piece of code missing and being used later. >> Not very sure of the code flow, but still as part of defensive >> programming. >> >> Am i missing something? > > conf->strip_zone is allocated with kzalloc, so all values are > initialised to 0. > zone->zone_start = 0; Sorry, this confused me. > NeilBrown > > >> >> >> >> -- >> Regards, >> Sandeep. >> >> >> >> >> >> >> “To learn is to change. Education is a process that changes the learner.” >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-raid" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- Regards, Sandeep. “To learn is to change. Education is a process that changes the learner.” -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
