Re: [ md/for-next git pull ] Support setting the array size from userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday March 17, dan.j.williams@xxxxxxxxx wrote:
> The following changes since commit 28453471bcdd767f22b8c03987f1acd73a8f34c3:
>   Atsushi SAKAI (1):
>         md: fix typo in FSF address
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/djbw/md.git md-array-size
> 
> Dan Williams (3):
>       md: add 'size' as a personality method
>       md: centralize ->array_sectors modifications
>       md: 'array_size' sysfs attribute

Thanks again.

I like "strict_blocks_to_sectors".  I wonder if there would ever by
any value it allowing it to parse 2000000.5 as 4000001 sectors ???
Probably not.

I don't feel comfortable about md_set_array_sectors_lock.
It makes me think there is something wrong with the locking somewhere.

Maybe we should have an explicit "end_reshape" method which is called
under the lock by md_check_recovery.  That would seem more "obviously
right".
I cannot see any demonstrable problem with the current code so I'll
take it as it is, but I might add a patch along those lines.

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux