Re: [mdadm git pull] "--assemble --scan" support for imsm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Neil Brown wrote:
I haven't included your

   Let symlinks to standard devices count as standard names

patch because I don't think I agree with it, and I don't think it is
needed any more.


My concern was that:
for i in `seq 1 5`
do
	mdadm -As
	mdadm -Ss
done

...would create 5 different device numbers. Your right it is better now, but between successive assemblies the device numbers still toggle between two different values. So it's just a small cosmetic issue now. Are their lifetime issues that preclude predictable device numbers?

I also have left out your

     imsm: match_home(), document why it is stubbed out
because I don't understand. Maybe some more words about how
'family_num' can distinguish between "Local" and "Foreign". ??


...it doesn't. 'family_num' is a checksum that includes the serial numbers of the component disks when the array was first created. So it can help determine when two arrays were created in different places, but the metadata can't identify which, if any, is "Local".

I'll redo the comment.

Thanks for the pull and the review,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux