On Monday June 23, chris@xxxxxxxxxxxx wrote: > Hi Neil. Thanks for your advice on this patch. And thank you for fixing it up. It looks good. I'll try to give is a proper review and do some testing myself in a few days. I'm a bit bothered about the code for leaving space for a bitmap for a 1.0 array. I'd rather avoid too much of this sort of 'policy' in the kernel. We could just leave it out and expect user-space to write a size that leaves room for a bitmap if that is needed, but maybe that is going too far the other way. I thought of just scaling the "space between end of data and start of metadata" by the same amount that the device is scaled, rounding up to the next sector. That feels "right" if it doesn't turn out to be too clumsy. Also, you add 4 lines greater than 80 columns :-) if you run ./scripts/checkpatch.pl name-of-patch-file it will tell you these things. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
