Michael Tokarev wrote:
Neil Brown wrote:
ffs is closer, but takes an 'int' and we have a 'unsigned long'.
So use ffz(~X) to convert a chunksize into a chunkshift.
So we don't use ffs(int) for an unsigned value because of int vs
unsigned int, but we use ffz() with negated UNSIGNED. Looks even
more broken to me, even if it happens to work correctly... ;)
No, it doesn't matter about the signedness, these are just bit
operations. The problem is the size (int vs. long), even though in
practice it's very unlikely you'd ever have a bitmap chunk size that
exceeded 32 bits. But it's better to be correct and not have to worry
about it.
--
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
