Neil Brown wrote: [] > Use ffz instead of find_first_set to convert multiplier to shift. > > From: Paul Clements <paul.clements@xxxxxxxxxxxx> > > find_first_set doesn't find the least-significant bit on bigendian > machines, so it is really wrong to use it. > > ffs is closer, but takes an 'int' and we have a 'unsigned long'. > So use ffz(~X) to convert a chunksize into a chunkshift. So we don't use ffs(int) for an unsigned value because of int vs unsigned int, but we use ffz() with negated UNSIGNED. Looks even more broken to me, even if it happens to work correctly... ;) /mjt - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
