On Thursday May 19, paul.clements@xxxxxxxxxxxx wrote: > Neil, > > hot add is not working for non-persistent superblock arrays (md is > trying, and failing, to read a superblock from the new disk)... > > attached patch fixes it... Yep, that looks good, thanks. NeilBrown > > Thanks, > Paul > > Signed-Off-By: Paul Clements <paul.clements@xxxxxxxxxxxx> > > md.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletion(-) > diff -purN --exclude-from /export/public/clemep/tmp/dontdiff linux-2.6.12-rc1-mm2-PRISTINE/drivers/md/md.c linux-2.6.12-rc1-mm2/drivers/md/md.c > --- linux-2.6.12-rc1-mm2-PRISTINE/drivers/md/md.c Fri Mar 25 14:33:36 2005 > +++ linux-2.6.12-rc1-mm2/drivers/md/md.c Thu May 19 16:29:44 2005 > @@ -2218,7 +2218,8 @@ static int add_new_disk(mddev_t * mddev, > mdname(mddev)); > return -EINVAL; > } > - rdev = md_import_device(dev, mddev->major_version, > + rdev = md_import_device(dev, mddev->persistent ? > + mddev->major_version : -1, > mddev->minor_version); > if (IS_ERR(rdev)) { > printk(KERN_WARNING - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html