Re: [PATCH] bio: set bi_idx after bio cloning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 16 2005, Mike Tran wrote:
> 
> Hi Jens,
> 
> Unless you have specific reason for not doing in __bio_clone(), I agree
> with Neil's suggestion.  Please consider the following patch:
> 
> --- linux-2.6.12-rc4-orig/fs/bio.c   2005-05-16 10:13:27.000000000 -0500
> +++ linux-2.6.12-rc4-patch/fs/bio.c   2005-05-16 10:15:06.000000000 -0500
> @@ -255,10 +255,7 @@
>         bio->bi_flags |= 1 << BIO_CLONED;
>         bio->bi_rw = bio_src->bi_rw;
> 
> -       /*
> -        * notes -- maybe just leave bi_idx alone. assume identical mapping
> -        * for the clone
> -        */
> +       bio->bi_idx = bio_src->bi_idx;
>         bio->bi_vcnt = bio_src->bi_vcnt;
>         bio->bi_size = bio_src->bi_size;
>         bio_phys_segments(q, bio);

That patch is fine with me, I'll add it. Thanks.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux