Lars Marowsky-Bree wrote: []
err = 0;
+ frdev = 0;
ITERATE_RDEV(mddev,rdev,tmp) {
char b[BDEVNAME_SIZE];
dprintk(KERN_INFO "md: ");
@@ -1296,13 +1298,21 @@ repeat:
dprintk("%s ", bdevname(rdev->bdev,b));
if (!rdev->faulty) {
- err += write_disk_sb(rdev);
+ int ret;
+ ret = write_disk_sb(rdev);
+ if (ret) {
+ frdev = rdev; /* Save failed device */
+ err += ret;
+ }
Why not + int ret; + ret = write_disk_sb(rdev); + if (ret) { + md_error(mddev, rdev); + err += ret; + }
instead (and remove frdev entirely)?
I mean, in theory, multiple disks may fail... But wait.. will md_error() call this routine again?
/mjt - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
