On Thu, Nov 04 2004, Jens Axboe wrote: > On Wed, Nov 03 2004, Andrew Morton wrote: > > NeilBrown <neilb@xxxxxxxxxxxxxxx> wrote: > > > > > > As the unplug timer can potentially fire at any time, and > > > and it access data that is released by the md ->stop function, > > > we need to del_timer_sync before releasing that data. > > > > I don't think I saw an update to this patch so I just knocked up the below > > simple conversion. If anyone can think up a nice description of what > > blk_sync_queue() should do, it would be appreciated ;) > > I don't see much merrit in this patch, you have to prevent new requests > from setting it off again. Basically, from my understanding, Neil needs > a way to atomically kill the timer and the unplug function. Correct? Actually, with the online io scheduler switching we have a way to do this already: blk_wait_queue_drained(q, 1); blk_sync_queue(q); Then you are sure the queue is idle, switch unplug (or ->make_request_fn) and: blk_finish_queue_drain(q); We need to move the ->rl waitqueue initializers to blk_queue_make_request() then. Would this work for you, Neil? -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
