On Wed, Nov 03 2004, Andrew Morton wrote: > NeilBrown <neilb@xxxxxxxxxxxxxxx> wrote: > > > > As the unplug timer can potentially fire at any time, and > > and it access data that is released by the md ->stop function, > > we need to del_timer_sync before releasing that data. > > I don't think I saw an update to this patch so I just knocked up the below > simple conversion. If anyone can think up a nice description of what > blk_sync_queue() should do, it would be appreciated ;) I don't see much merrit in this patch, you have to prevent new requests from setting it off again. Basically, from my understanding, Neil needs a way to atomically kill the timer and the unplug function. Correct? -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html