On Tuesday June 8, paul.clements@xxxxxxxxxxxx wrote:
> Neil,
>
> Here's the latest patch...it supports bitmaps in files as well as block
> devices (disks or partitions), contrary to what I had stated in my
> previous e-mail. I've tried to address all the issues you've pointed
> out, and generally cleaned up and fixed the patch some more...details
> below...
This looks a lot better. There are a few little issues that I noticed
on a quick read through:
- last_block_device should return "sector_t", not "unsigned
long". It would be worth checking for other placed that
sector_t might be needed.
- bitmap_checkpage still isn't quite safe. If "hijacked" gets
set while it is allocating a page (unlikely, but possible), it
will exit with both highjacked set and an allocated page, which
isn't right.
- The event comparison
+ sb->events_hi >= refsb->bitmap_events_hi &&
+ sb->events_lo >= refsb->bitmap_events_lo) {
in hot_add_disk is wrong.
I'll try to make time to try the patch out in a week or so to get a
better feel for it.
The changes to mdadm need a bit of work.
You have added "--persistent" and "--non-persistent" flags for
--create. This is wrong.
--create always uses persistent superblocks.
--build makes arrays without persistent superblocks.
I don't think I like --create-bitmap. A bitmap file should always be
created in the context of a particular array (partly so that the size
and uuid can be set correctly). I think I would like to bitmap to be
specified as a "--bitmap=filename" option to --create, --build, or
--grow. I haven't thought this through in great detail yet, but that
is my leaning.
--examine-bitmap is a bit of a pain too. I think I would like
--examine to figure out what it has been given to look at, and report
on whatever it finds.
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
