On Tuesday March 11, ARechenberg@shermanfinancialgroup.com wrote:
With Kevin's patch from last week and some help from Randy, I patched the md code in Red Hat 2.4.18-26.7.x to use the seq_file interface for mdstat. I've attached the patch. As with Kevin's patch, it touches almost everything in drivers/md, as well as adding the necessary methods to fs/seq_file.c and include/linux/seq_file.h.
While this patch quite possibly works, I think it misses the point of seq_file.
seq_file allows you to return the content of a possibly-large file in lots of little bits, so multiple 'read' calls on the file don't iterrate over the whole file every time.
I recently sent a patch to Linus for 2.5 that converts /proc/mdstat to use seq_file using what I understand to be the intended approach, and I have just posted as similar patch for 2.4 to Marcelo. I expect it appeared on linux-raid before you saw this...
Yep, saw it, it's most definitely a better solution. My solution was quick and dirty, only get it to stop oopsing (and so I could actually monitor my arrays).
- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
