Re: [PATCH] convert md to use seq_file for /proc/mdstat

["Kevin P. Fleming" <kpfleming@cox.net>]

Paul Clements wrote:
> Hi Kevin,
>
> I like the patch. I'm just curious...why'd you axe the CONFIG_PROC_FS
> ifdef's ?
>
> --
> Paul
>
>
>
> > -#ifdef CONFIG_PROC_FS
> > -       create_proc_read_entry("mdstat", 0, NULL, md_status_read_proc, NULL);
> > -#endif
>
>
> > -#ifdef CONFIG_PROC_FS
> >        remove_proc_entry("mdstat", NULL);
> > -#endif
Two reasons, really:

- constant harping on LKML about how everyone hates #ifdefs <G>
- <linux/proc_fs.h> provides "return NULL" inline versions of these 
functions if CONFIG_PROC_FS is not defined, so presumably the compiler 
will just compile them away in that situation

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html