> The first chunk of yor patch is in bind_rdev_to_array. > This is called from > autorun_devices which has just allocated the mddev so the > semaphore is still locked (it is allocated locked, and > then unlocked). Ok, got this. And after autorun_devices calls bind_rdev_to_arry, it must first call autorun_array - so my hunk of the patch that modifies that section of the code is clearly wrong - it actually drops the semaphore when it should still be held. Then am I correct in determining that this semaphore isn't dropped until the exit from md_ioctl? If that is indeed the case, I'm pretty confident that the md.c code is correct as it. Ross Vandegrift ross@willow.seitz.com - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html