On 15 September 2017 at 15h44, Tanu Kaskinen wrote: Hi, > [...] Thanks for your detailed review. I reworked the patch to follow your advices. In particular, I've made all latency parameter handling and passing to use milliseconds, only use microseconds at the only place needed. For initializing the optional parameters to the default (2s) value if not passed, I had to do a double if() to check for the parameter's existence first. Nevertheless, it's cleaner than before. Attached is an updated patch. Thanks! -- Colin -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-RAOP-Announce-real-latency.patch Type: text/x-patch Size: 7528 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170915/869170b9/attachment-0001.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 801 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170915/869170b9/attachment-0001.sig>
