On Tue, 10 May 2016, at 10:17 PM, Tanu Kaskinen wrote: > On Mon, 2016-05-09 at 15:40 +0530, Arun Raghavan wrote: > > @@ -369,6 +369,8 @@ int pa_card_suspend(pa_card *c, bool suspend, pa_suspend_cause_t cause) { > > Â Â Â Â Â else > > Â Â Â Â Â Â Â Â Â c->suspend_cause &= ~cause; > > Â > > +Â Â Â Â pa_hook_fire(&c->core->hooks[PA_CORE_HOOK_CARD_SUSPEND_CHANGED], c); > > I'd like to have a check that ensures that c->suspend_cause actually > changed before firing the hook. Thanks for the review -- did this and pushed now. -- Arun