On Fri, 2016-03-25 at 01:38 +0900, Sangchul Lee wrote: > > > +Â Â Â Â roles = pa_modargs_get_value(ma, "trigger_roles", NULL); > > > +Â Â Â Â if (roles) { > > > +Â Â Â Â Â Â Â Â const char *group_split_state = NULL; > > > +Â Â Â Â Â Â Â Â char *roles_in_group = NULL; > > > +Â Â Â Â Â Â Â Â i = 0; > > > +Â Â Â Â Â Â Â Â while ((roles_in_group = pa_split(roles, "/", &group_split_state))) { > > > +Â Â Â Â Â Â Â Â Â Â Â Â if (roles_in_group[0] != '\0') { > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â const char *split_state = NULL; > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â char *n = NULL; > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â while ((n = pa_split(roles_in_group, ",", &split_state))) { > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (n[0] != '\0') > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â pa_idxset_put(u->trigger_roles[i], n, NULL); > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â else > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â pa_xfree(n); > >Â > > If an empty string is given as a role name, I think that should be an > > error. >Â > Â I understood your meaning that if an empty string is given as a role > name, then not proceed next step and return error. Am I right? Yes. --Â Tanu