[RFC][PATCH] improve missing handling in memblockq (was Re: stream wedged in non-playing state)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 01 Jun 2016 15:31:57 +0530
Arun Raghavan <arun at arunraghavan.net> wrote:

> 
> I don't have good example as such, but I do know the alsa pulse plugin
> for example sets different flags (and buffer attrs?) from the more
> standard async clients.
> 

I tried a few different ALSA applications without any glitches:

 - aplay
 - mplayer
 - flash in firefox

> We have an old test for creating a simple set of streams as a sanity
> check. Maybe this could be extended to run with different combinations
> of flags and attributes.
> 
>   http://cgit.freedesktop.org/pulseaudio/pulseaudio/tree/src/tests/sync-playback.c
> 

Triggering the bug requires a specific amount of data to be drained,
which is difficult to achieve in any sensible manner just by being a
client. :/

I added the attached test though. It doesn't test the full scope of the
bug as it doesn't include the native protocol side of things, but it
should verify correct minreq behaviour in the core (which in turn
should avoid bugs further out).

Hopefully that's sufficient for now?

Rgds
-- 
Pierre Ossman           Software Development
Cendio AB		https://cendio.com
Teknikringen 8		https://twitter.com/ThinLinc
583 30 Linköping	https://facebook.com/ThinLinc
Phone: +46-13-214600	https://plus.google.com/+CendioThinLinc

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-add-test-to-verify-correct-minreq-behaviour.patch
Type: text/x-patch
Size: 3324 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20160608/9d2f8acc/attachment.bin>


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux