On Fri, 2016-01-29 at 11:11 +1100, Chris Billington wrote: > Hi all, > > I was wondering if anyone has had the time to look at my patch? > > No rush if there are more important things to be doing! I haven't had time yet. I will get to it eventually. > > The other four patches are implementing the setting of individual latency > > offsets of sinks and sources. This now plays nicely with port latency > > offsets. The way I've done this is to rename everything pertaining to the > > latency offsets inherited from ports, so that they are all called > > sink->port_latency_offset etc. Then I've introduced a new latency offset > > for sinks and sources, called just sink->latency_offset etc, which is for > > the latency offset set on that sink or source alone. The total latency > > reported by the device then includes the sum of both of them. Sounds very good. > > The only thing I didn't do was restoring from disk. Tanu, you said this > > might be tricky, but I wasn't able to understand module-device-restore > > enough to even see the trickiness you were talking about, I wasn't able to > > get that far! I'm not very familiar with the codebase - I'm just here > > selfishly to try and get my feature in so my application works better :p. > > So apologies for that, I hope the changes are worthy without it. I think it's ok to leave the persistence feature out. --Â Tanu
