On Thu, 2016-02-18 at 17:09 +0100, Georg Chini wrote: > On 18.02.2016 10:40, Arun Raghavan wrote: > > On Thu, 2016-02-11 at 23:11 +0900, Sangchul Lee wrote: > > > Fix improper unducking behavior when using this module with > > > "global=1" argument. > > > > > > BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=93994 > > > > > > Signed-off-by: Sangchul Lee <sc11.lee at samsung.com> > > > --- > > Looks good to me, pushed thanks. > > > > -- Arun > > _______________________________________________ > > pulseaudio-discuss mailing list > > pulseaudio-discuss at lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > Hi Arun, > > there has been a patch series I sent a while ago which combines module > role-cork > and module-role-ducking because they contain lots of duplicated code. > This series has > never been reviewed. Maybe you can take a look at it? > You can find it at > http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/23189 I think this does make sense. The stream selection logic is the same between the two modules, and it's only what we do after selecting the stream that changes. I'll try to get to this after reviewing the RAOP series. Thank you for your patience. Regards, Arun
