On Wed, 2016-02-17 at 15:54 +0200, Tanu Kaskinen wrote: > On Wed, 2016-02-17 at 18:40 +0530, Arun Raghavan wrote: > > On Wed, 2016-02-17 at 18:36 +0530, Arun Raghavan wrote: > > > On Tue, 2016-02-16 at 14:20 +0200, Tanu Kaskinen wrote: > > > > On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote: > > > > > +Â Â Â Â /* FIXME: we need to be able to modify playback samples */ > > > > > > > > This comment should say also why we need to be able to modify them > > > > (and > > > > I also don't understand what's preventing us from doing so now). > > > > > > Reworded this as: > > > > > > /* FIXME: we need to be able to modify playback samples, which we can't > > > Â * currently do. This is because module-echo-cancel processes playback > > > Â * frames in the source thread, and just stores playback chunks as they > > > Â * pass through the sink. */ > > Mmmh, that still doesn't answer the question why we need to be able to > modify playback samples. What processing do we want to do that we can't > currently do? ProcessReverseStream() *may* change samples. Currently, this only happens when you enable the intelligibility enhancer. -- Arun
