[PATCH v2 11/12] pulse: client audio: Use memfd transport by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 13, 2016 at 11:47:12AM +0200, Tanu Kaskinen wrote:
> On Fri, 2016-02-12 at 14:17 +0100, David Henningsson wrote:
> > 
> > On 2016-02-12 01:20, Ahmed S. Darwish wrote:
...
> > > @@ -107,6 +107,11 @@ License along with PulseAudio; if not, see .
> > >       
> > > +      disable-memfd=. Disable memfd shared memory. Takes
> > > +      a boolean argument, defaults to no.
> > 
> > Good idea.
> 
> The option should be "enable-memfd" rather than "disable-memfd",
> though. "disable-memfd=no" is a double negative, and it's good to
> avoid double negatives. (In the past we have had negative options
> that have later been superseded by positive ones, which is why we
> support both versions for some options, such as disable-shm/enable-shm.)
> 

Thanks for the rationale ;-) Now fixed in v3.

-- 
Darwish
http://darwish.chasingpointers.com


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux