On 22.01.2016 04:06 PM, Tanu Kaskinen wrote: > On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote: >> From: Arun Raghavan <git at arunraghavan.net> >> >> The code now needs C++11 support to compile with the updated >> webrtc-audio-processing library. >> --- >> configure.ac | 2 +- >> src/Makefile.am | 2 +- >> src/modules/echo-cancel/webrtc.cc | 54 +++++++++++++++++++++------------------ >> 3 files changed, 31 insertions(+), 27 deletions(-) > > Looks good to me! Actually... doesn't this deserve a check in configure if the compiler actually supports C++11? If it doesn't, why make C++11 mandatory for everything? It should only be used for the webrtc-audio-processing lib and otherwise leave CXXFLAGS untouched (with webrtc-audio-processing being optional, as far as I've seen.) Mihai -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 884 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20160211/cdef3517/attachment.sig>
