Hi Hajime, I'm still working on this, it's slow going since I have other things to do in parallel. It's a bit hard to review this work properly per-commit, so I'm going to try to summarise the issues I've found at one go. * There are some style issues that I'm fixing up as I find, and I'll just have that as a commit on top of your tree. * While testing, I see there are two instances loaded every time (one for IPv4 and one for IPv6) -- wouldn't it be more user friendly to make sure we load only one? This doesn't appear to be a new issue, so not a blocker on this series * I tried this against Airserver on a Mac (worked) and a current generation Apple TV (did not work) -- just got stuck trying to start playback Will reply again once I'm through the patch set. Regards, Arun On Wed, 2016-02-10 at 18:50 -0600, Hajime Fujita wrote: > Hi Arun, > > Are you still going through the patches? > If you are done, I'll submit a new series of patches that address > your comments. > > > Thanks, > Hajime > > Hajime Fujita wrote: > > Arun Raghavan wrote: > > > On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote: > > > > From: Hajime Fujita <crisp.fujita at nifty.com> > > > > > > > > This is basically same as the previous patch series, > > > > with several patches squashed for conciseness, rebased > > > > on the latest master. > > > > http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-O > > > > ctober > > > > /024547.html > > > > > > > > This patch set adds a support for UDP version of RAOP (so > > > > called > > > > raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress, > > > > third party AV receivers) today use UDP version, so this patch > > > > set is expected to support those devices. > > > > > > > > Also the patches can be seen from here: > > > > https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf... > > > > hf/rao > > > > p2-v4-v8.0 > > > > > > > > > > Thank you for your perseverance in getting this through. I'm > > > going to > > > try to do a pass through the list in the coming days. > > > > > > I'm using the raop2-v4-v8.0 branch. Please let me know if I > > > should be > > > looking at something else. > > > > Hi Arun, > > > > Thank you for taking a look at this. > > Yes, that is the right one. I'll start addressing your comments. > > > > > > Best, > > Hajime > > > > > > > > Regards, > > > Arun > > > _______________________________________________ > > > pulseaudio-discuss mailing list > > > pulseaudio-discuss at lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > > > > > > > _______________________________________________ > > pulseaudio-discuss mailing list > > pulseaudio-discuss at lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > > > > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
