On 7 April 2016 at 20:02, Tanu Kaskinen <tanuk at iki.fi> wrote: > On Mon, 2016-02-29 at 15:46 +0530, arun at accosted.net wrote: >> -pa_rtp_context* pa_rtp_context_init_send(pa_rtp_context *c, int fd, uint32_t ssrc, uint8_t payload, size_t frame_size); >> +bool pa_rtp_context_init_send(pa_rtp_context *c, int fd, uint32_t ssrc, uint8_t payload, size_t frame_size); > > The function never fails, so what's the point of this patch? I'll add this to the commit message, but this is basically for consistency later when I add an RTP implementation which can fail. > (Also, a reminder: we've agreed to report function failures using a > negative int value rather than a bool.) Was that only for external functions, or internal ones as well? -- Arun
