[PATCH] mainwindow: Don't add a border on the outermost vbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-03-31 at 18:05 +0500, Alexander E. Patrakov wrote:
> 31.03.2016 16:44, arun at accosted.net пиÑ?еÑ?:
> > 
> > From: Arun Raghavan <git at arunraghavan.net>
> > 
> > It adds a thick border around along the edges that looks quite ugly.
> The patch does what it says, but the GtkNotebook tabs "glued" to the top 
> of the window also don't look nice in MATE from my viewpoint. Caja's 
> settings dialog (and some other MATE settings dialogs that use tabbed 
> notebooks, as well as pitivi's Project Settings dialog) has this thick 

What Pitivi and the GNOME Sound Settings are doing is adding a small
border and enabling show-border, which makes an inset notebook. Doing
that at the top-level (~5px border and inset) at the top-level looks
about as strange as no border to me.

> border. OTOH, MATE terminal does the ugly "tabs glued to the titlebar" 
> thingy if one hides the menu, the same is also seen in linphone preferences.
> 
> So - no real (consistency-based) opinion here. If you can find anything 
> in the HIG that explains that the border should not exist in this case, 
> please add a link in the commit message, and/or quote directly, and push it.

The HIG way of doing things would probably mean dropping GTK 2 support
and doing something like: https://developer.gnome.org/hig/stable/view-s
witchers.html.en

-- Arun


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux