On Thu, 21 May 2015, Tanu Kaskinen wrote: > On Wed, 2015-05-20 at 22:42 +0200, Peter Meerwald wrote: > > From: Peter Meerwald <p.meerwald at bct-electronic.com> > > > > see https://bugs.freedesktop.org/show_bug.cgi?id=89539 > > > > Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net> > > --- > > src/pulsecore/rtpoll.c | 11 ++++------- > > src/pulsecore/rtpoll.h | 4 ---- > > 2 files changed, 4 insertions(+), 11 deletions(-) > > > > diff --git a/src/pulsecore/rtpoll.c b/src/pulsecore/rtpoll.c > > index f427ef3..a6d323b 100644 > > --- a/src/pulsecore/rtpoll.c > > +++ b/src/pulsecore/rtpoll.c > > @@ -557,7 +557,10 @@ static int asyncmsgq_read_work(pa_rtpoll_item *i) { > > > > if (!object && code == PA_MESSAGE_SHUTDOWN) { > > pa_asyncmsgq_done(i->userdata, 0); > > - pa_rtpoll_quit(i->rtpoll); > > + /* Requests the loop to exit. Will cause the next iteration of > > + * pa_rtpoll_run() to return 0 */ > > + pa_assert(i->rtpoll); > > This assertion seems redundant. i->rtpoll is set when i is created, and > it never changes. > > Otherwise the patch looks good. applied with the change indicated, and resolved bugzilla issue thanks, p. -- Peter Meerwald +43-664-2444418 (mobile)
