24.03.2015 14:29, David Henningsson wrote: > The resampler framework just forwards the request to the lfe filter. > There are no resampler impl that can rewind yet, so just reset the > resampler impl instead of properly rewinding yet. There is still one unanswered concern, originally expressed here: http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023076.html > +/* Rewind resampler */ > +void pa_resampler_rewind(pa_resampler *r, size_t amount); > + I originally wrote (see the URL above) that it may be the wrong prototype to implement. I still have that opinion. However, now I also think that it would be wrong to ask for fixing the issue now, as it, essentially, requires an attempt to implement a rewindable resampler, which is not the aim of this patch series. For now, please add a comment about the meaning of the "amount" parameter - i.e. whether it is in samples before or after resampling, and maybe a comment that there is a doubt whether this signature is actually suitable in the general case. What is certain is that this works as a useful temporary solution in the no-resampling case, where only the LFE filter has to be rewound. -- Alexander E. Patrakov
