On 22.03.2015 22:47, Luke Yelavich wrote: > On Mon, Mar 23, 2015 at 12:25:05AM AEDT, Georg Chini wrote: >> This patch set combines the functionality of module-role-cork and module-role-ducking. >> Module name is still module-role-cork (module-role-cork-duck somehow sounds a bit >> like module-rubber-duck ...). >> If you specify a volume, streams will be ducked, otherwise muted/corked. >> It also adds support for streams without media.role and reacts to mute/cork >> changes of the trigger stream and to property list changes. > I am not sure if this is a good idea. I can think of situations where a client application wants to make streams of a particular role duck. The use case I have in mind is a vision impaired/blind user using a screen reader. The screen reader wants to duck all audio except the speech synthesizer, such that the user can more easily hear it. In addition, the user may want the audio for certain roles corked when there is an incoming VOIP call. > > No idea if your revised module can do this, so I may be jumping the gun. The functionality I speak of is not implemented anywhere yet, but it is something that may be done in the future. > It can't do that right now, but the functionality could easily be added. It would only need an additional parameter duck_roles, so that cork_roles would be corked while duck_roles would only be ducked. I can implement it if this is needed. Georg
