On 2015-02-16 12:35, Alexander E. Patrakov wrote: > 16.02.2015 15:52, David Henningsson wrote: >> Well, the big issue I guess is that in current state, >> PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY messages always return 0. >> >> Maybe there should be a sentence about that, or I could just push it as >> it is. What do you think? > > Well, I did not think about the exact message being hidden. I only > noticed that the enum did not use the = PA_SOURCE_OUTPUT_MESSAGE_MAX. > But of course, you are right. So here is an alternative commit message, > please use it if you like it better. > > loopback: don't use 0 for custom source output message id > > Message id 0 is PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY. So, every time > PulseAudio sent PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY message to the > loopback source output, it actually hit the > SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT handler instead. As a result, the > SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT handler was called when not > intended, the default PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY handler was > not called at all, and the latency was thus evaluated incorrectly. > > Signed-off-by: Alexander E. Patrakov <patrakov at gmail.com> Thanks, pushed now with an added "Reported-by" in the commit message. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
