[PATCH v3 4/6] conf-parser: Add pa_config_parse_volume()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2015-04-28 10:17, Tanu Kaskinen wrote:
> On Tue, 2015-04-28 at 09:39 +0200, David Henningsson wrote:
>>
>> On 2015-04-27 13:34, Tanu Kaskinen wrote:
>>> This will be used to parse the path default volume in the alsa mixer
>>> configuration files. For now, percentages are the only supported
>>> format, because I don't have need for anything else, but we can of
>>> course add more volume formats later as needed.
>>
>> My preference for allowing all volume formats is quite strong;
>> specifically considering that volume percentages are frowned upon as
>> meaning different things in different contexts (so newcomers to
>> PulseAudio don't have to figure out what *we* mean with it before being
>> able to write the config).
>
> Ok, I'll support dB and raw pa_volume_t too, then.

Thanks.

> Should I also add
> support for linear multiplication factors for completeness? pactl parses
> "0.5" as a multiplier that gets applied to each sample, but
> pa_parse_volume() doesn't support that currently.

No strong preference here - if you're planning to merge pactl's volume 
handling with pa_parse_volume too, sounds like you would end up doing it 
anyway?

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux