On 16 April 2015 at 10:23, Arun Raghavan <arun at accosted.net> wrote: > On 16 April 2015 at 18:50, Felipe Sateler <fsateler at debian.org> wrote: >> On 16 April 2015 at 03:24, David Henningsson >> <david.henningsson at canonical.com> wrote: >>> >>> * check - needed if we want travis to run "make check". (We could consider >>> adding a "make check" when we build pulseaudio, it's a trade-off between >>> increased build times and the chance of discovering something - personally I >>> think the risk that make check would actually fail is so low that I wonder >>> if it's worth running it as part of every build) >> >> Perhaps automatically running it would encourage adding more tests :) > > I don't like this idea -- it'd just increase build times. We should be > running tests when we intend to, and having CI means that if we forget > to, we'll know the hard way. :-) So, to clarify: I am not advocating running check during a normal build. But check is needed to run make check on travis, and I obviously think check should be run in the CI server. -- Saludos, Felipe Sateler
