[PATCH] Add HDMI 5.1 and 7.1 profiles to default.conf as well

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



13.07.2014 20:07, Tanu Kaskinen wrote:
> On Sun, 2014-07-13 at 19:49 +0600, Alexander E. Patrakov wrote:
>> Signed-off-by: Alexander E. Patrakov <patrakov at gmail.com>
>> ---
>>   src/modules/alsa/mixer/profile-sets/default.conf | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> Tanu Kaskinen wrote:
>>
>>> Somewhat related, I also wonder why the surround mappings (both 5.1 and
>>> 7.1) are only in extra-hdmi.conf. My understanding is that the point of
>>> extra-hdmi.conf is just to offer the additional mappings for the
>>> subdevices 1-3, so the non-extra surround profiles should be copied to
>>> all other profile-set files too.
>>
>> Valid point, let's add the surround profiles to default.conf
>
> If they're added to default.conf, they should be added to
> extra-hdmi.conf (it only has 5.1), force-speaker.conf and
> force-speaker-and-int-mic.conf too.

OK, it looks like you prefer to get a single patch that adds the HDMI 
5.1 and 7.1 profiles to all conf files where it makes sense. I will work 
on this (but see below).

> And before you say anything, yes,
> this duplication is bad, feel free to fix it. I believe it would work if
> the other files would include default.conf, the syntax is
>
> .include default.conf

Thanks for the very constructive suggestion. I will definitely look into 
it, and send out the patch later, but this has to happen after I look 
into David's question about measuring the timings related to probing.

-- 
Alexander E. Patrakov


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux