On Thu, Jul 11, 2013 at 09:13:05AM EST, Peter Meerwald wrote: > Hello, > > > > This commit seems to break speech-dispatcher: > > > http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=30ce3a14e5ae1cd316a18bec95b831c07ac57a1a > > this is not good > > > buffer handling. Converting o_ss.channels to work_channels isn't enough > > to fix the issue with speech-dispatcher, however, because there's also > > another thing issue: when resampling happens before remapping, the > > leftover buffer handling is completely broken, because it assumes that > > the leftover data from the resampling phase is supposed to be stored in > > the remap buffer, while it actually should be stored in the > > to_work_format buffer. At least the ffmpeg resampler needs the leftover > > handling with the speech-dispatcher stream. I don't have a simple fix > > for this, so I'll just revert the patch for now. > > the ffmpeg and libsamplerate code use the leftover logic; I assume > speech-dispatcher selects ffmpeg or libsamplerate instead of the default > speex? or is the bug due to the issue in the peaks resampler? Speech-dispatcher does not change the resampler algorithm used. Luke
