[PATCH 2/2] context: add cookie loaders + setter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(Added pulseaudio-discuss back to CC.)

On Wed, 2013-08-21 at 13:07 +0200, Alexander Couzens wrote:
> On Wed, 21 Aug 2013 08:49:46 +0300
> Tanu Kaskinen <tanu.kaskinen at linux.intel.com> wrote:
> 
> > Actually, having the cookie_size parameter seems a bit silly, since only
> > one value will be accepted. On the other hand, it's nice to have some
> > way of forcing the client to think about the buffer size... I have
> > trouble deciding what I want the interface to look like. The most
> > pleasant way forward would be to avoid the decision and drop
> > pa_context_set_cookie() and pa_context_load_cookie_from_hex()
> > altogether. AFAIK you don't need those functions anyway. If we need the
> > functionality in the future (pretty unlikely), it can be added later.
> 
> IMHO: As an application programmer I wouldn't like the way of creating a file only because 
> pulseaudio accepts only files as cookie or setting the environment. Authentication is a 
> part of the connection parameters and thus it should be set direct by a call.

If you can show that there exists an application programmer that wants
to set the cookie directly, then sure, let's add an API for that. The
reality, however, is that nobody has ever asked for that functionality,
and the only motivation for adding an API for cookies now is that the
tunnel modules need it, and they don't need to set the cookie directly.

-- 
Tanu



[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux