Signed-off-by: Alexander Couzens <lynxis at fe80.eu> --- src/pulsecore/thread-mq.c | 74 ++++++++++++++++++++++++++++++++++++++++------- src/pulsecore/thread-mq.h | 7 +++-- 2 files changed, 68 insertions(+), 13 deletions(-) diff --git a/src/pulsecore/thread-mq.c b/src/pulsecore/thread-mq.c index dd84c9a..12e6d4e 100644 --- a/src/pulsecore/thread-mq.c +++ b/src/pulsecore/thread-mq.c @@ -30,18 +30,27 @@ #include <pulsecore/semaphore.h> #include <pulsecore/macro.h> +#include <pulse/mainloop-api.h> + #include "thread-mq.h" PA_STATIC_TLS_DECLARE_NO_FREE(thread_mq); -static void asyncmsgq_read_cb(pa_mainloop_api*api, pa_io_event* e, int fd, pa_io_event_flags_t events, void *userdata) { +static void asyncmsgq_read_cb(pa_mainloop_api *api, pa_io_event *e, int fd, pa_io_event_flags_t events, void *userdata) { pa_thread_mq *q = userdata; pa_asyncmsgq *aq; - pa_assert(pa_asyncmsgq_read_fd(q->outq) == fd); pa_assert(events == PA_IO_EVENT_INPUT); - pa_asyncmsgq_ref(aq = q->outq); + if (pa_asyncmsgq_read_fd(q->outq) == fd) + pa_asyncmsgq_ref(aq = q->outq); + else if (pa_asyncmsgq_read_fd(q->inq)) + pa_asyncmsgq_ref(aq = q->inq); + else { + pa_assert(false); + return; + } + pa_asyncmsgq_read_after_poll(aq); for (;;) { @@ -55,6 +64,12 @@ static void asyncmsgq_read_cb(pa_mainloop_api*api, pa_io_event* e, int fd, pa_io while (pa_asyncmsgq_get(aq, &object, &code, &data, &offset, &chunk, 0) >= 0) { int ret; + if (!object && code == PA_MESSAGE_SHUTDOWN) { + pa_asyncmsgq_done(aq, 0); + api->quit(api, 0); + break; + } + ret = pa_asyncmsgq_dispatch(object, code, data, offset, &chunk); pa_asyncmsgq_done(aq, ret); } @@ -66,7 +81,7 @@ static void asyncmsgq_read_cb(pa_mainloop_api*api, pa_io_event* e, int fd, pa_io pa_asyncmsgq_unref(aq); } -static void asyncmsgq_write_cb(pa_mainloop_api*api, pa_io_event* e, int fd, pa_io_event_flags_t events, void *userdata) { +static void asyncmsgq_write_inq_cb(pa_mainloop_api *api, pa_io_event *e, int fd, pa_io_event_flags_t events, void *userdata) { pa_thread_mq *q = userdata; pa_assert(pa_asyncmsgq_write_fd(q->inq) == fd); @@ -76,19 +91,50 @@ static void asyncmsgq_write_cb(pa_mainloop_api*api, pa_io_event* e, int fd, pa_i pa_asyncmsgq_write_before_poll(q->inq); } +static void asyncmsgq_write_outq_cb(pa_mainloop_api *api, pa_io_event *e, int fd, pa_io_event_flags_t events, void *userdata) { + pa_thread_mq *q = userdata; + + pa_assert(pa_asyncmsgq_write_fd(q->outq) == fd); + pa_assert(events == PA_IO_EVENT_INPUT); + + pa_asyncmsgq_write_after_poll(q->outq); + pa_asyncmsgq_write_before_poll(q->outq); +} + +void pa_thread_mq_init_thread_mainloop(pa_thread_mq *q, pa_mainloop_api *main_mainloop, pa_mainloop_api *thread_mainloop) { + pa_assert(q); + pa_assert(main_mainloop); + pa_assert(thread_mainloop); + + pa_assert_se(q->inq = pa_asyncmsgq_new(0)); + pa_assert_se(q->outq = pa_asyncmsgq_new(0)); + + q->main_mainloop = main_mainloop; + + pa_assert_se(pa_asyncmsgq_read_before_poll(q->outq) == 0); + pa_asyncmsgq_write_before_poll(q->outq); + pa_assert_se(q->read_main_event = main_mainloop->io_new(main_mainloop, pa_asyncmsgq_read_fd(q->outq), PA_IO_EVENT_INPUT, asyncmsgq_read_cb, q)); + pa_assert_se(q->write_thread_event = main_mainloop->io_new(thread_mainloop, pa_asyncmsgq_write_fd(q->outq), PA_IO_EVENT_INPUT, asyncmsgq_write_outq_cb, q)); + + pa_asyncmsgq_read_before_poll(q->inq); + pa_asyncmsgq_write_before_poll(q->inq); + pa_assert_se(q->read_thread_event = thread_mainloop->io_new(thread_mainloop, pa_asyncmsgq_read_fd(q->inq), PA_IO_EVENT_INPUT, asyncmsgq_read_cb, q)); + pa_assert_se(q->write_main_event = main_mainloop->io_new(main_mainloop, pa_asyncmsgq_write_fd(q->inq), PA_IO_EVENT_INPUT, asyncmsgq_write_inq_cb, q)); +} + void pa_thread_mq_init(pa_thread_mq *q, pa_mainloop_api *mainloop, pa_rtpoll *rtpoll) { pa_assert(q); pa_assert(mainloop); - q->mainloop = mainloop; + q->main_mainloop = mainloop; pa_assert_se(q->inq = pa_asyncmsgq_new(0)); pa_assert_se(q->outq = pa_asyncmsgq_new(0)); pa_assert_se(pa_asyncmsgq_read_before_poll(q->outq) == 0); - pa_assert_se(q->read_event = mainloop->io_new(mainloop, pa_asyncmsgq_read_fd(q->outq), PA_IO_EVENT_INPUT, asyncmsgq_read_cb, q)); + pa_assert_se(q->read_main_event = mainloop->io_new(mainloop, pa_asyncmsgq_read_fd(q->outq), PA_IO_EVENT_INPUT, asyncmsgq_read_cb, q)); pa_asyncmsgq_write_before_poll(q->inq); - pa_assert_se(q->write_event = mainloop->io_new(mainloop, pa_asyncmsgq_write_fd(q->inq), PA_IO_EVENT_INPUT, asyncmsgq_write_cb, q)); + pa_assert_se(q->write_main_event = mainloop->io_new(mainloop, pa_asyncmsgq_write_fd(q->inq), PA_IO_EVENT_INPUT, asyncmsgq_write_inq_cb, q)); pa_rtpoll_item_new_asyncmsgq_read(rtpoll, PA_RTPOLL_EARLY, q->inq); pa_rtpoll_item_new_asyncmsgq_write(rtpoll, PA_RTPOLL_LATE, q->outq); @@ -106,15 +152,21 @@ void pa_thread_mq_done(pa_thread_mq *q) { if (!pa_asyncmsgq_dispatching(q->outq)) pa_asyncmsgq_flush(q->outq, true); - q->mainloop->io_free(q->read_event); - q->mainloop->io_free(q->write_event); - q->read_event = q->write_event = NULL; + q->main_mainloop->io_free(q->read_main_event); + q->main_mainloop->io_free(q->write_main_event); + q->read_main_event = q->write_main_event = NULL; + + if (q->thread_mainloop) { + q->thread_mainloop->io_free(q->read_thread_event); + q->thread_mainloop->io_free(q->write_thread_event); + q->read_thread_event = q->write_thread_event = NULL; + } pa_asyncmsgq_unref(q->inq); pa_asyncmsgq_unref(q->outq); q->inq = q->outq = NULL; - q->mainloop = NULL; + q->main_mainloop = NULL; } void pa_thread_mq_install(pa_thread_mq *q) { diff --git a/src/pulsecore/thread-mq.h b/src/pulsecore/thread-mq.h index a1f4b3f..79af364 100644 --- a/src/pulsecore/thread-mq.h +++ b/src/pulsecore/thread-mq.h @@ -31,12 +31,15 @@ * attached to the thread using pa_thread_mq_install(). */ typedef struct pa_thread_mq { - pa_mainloop_api *mainloop; + pa_mainloop_api *main_mainloop; + pa_mainloop_api *thread_mainloop; pa_asyncmsgq *inq, *outq; - pa_io_event *read_event, *write_event; + pa_io_event *read_main_event, *write_main_event; + pa_io_event *read_thread_event, *write_thread_event; } pa_thread_mq; void pa_thread_mq_init(pa_thread_mq *q, pa_mainloop_api *mainloop, pa_rtpoll *rtpoll); +void pa_thread_mq_init_thread_mainloop(pa_thread_mq *q, pa_mainloop_api *main_mainloop, pa_mainloop_api *thread_mainloop); void pa_thread_mq_done(pa_thread_mq *q); /* Install the specified pa_thread_mq object for the current thread */ -- 1.8.3.4