On Fri, 2013-08-02 at 08:44 +0200, Thomas Martitz wrote: > Am 02.08.2013 02:10, schrieb Jo?o Paulo Rechi Vita: > > On Fri, Jul 19, 2013 at 7:24 AM, Tanu Kaskinen > > <tanu.kaskinen at linux.intel.com> wrote: > >> (Sorry, I sent the previous mail too early. I hadn't yet finished > >> reviewing this patch.) > >> > >> On Fri, 2013-07-12 at 15:06 -0300, jprvita at gmail.com wrote: > >>> + > >>> + if (strcasecmp(key, "UUID") == 0) { > >> What is the reason to use strcasecmp() instead of pa_streq()? > >> > > This was copied from previous code, I'm changing it to pa_streq. > > > Not sure if it matters here but pa_streq() doesn't ignore the case in > contrast to strcasecmp(). So it's not completely equivalent. Yes, I asked what the reason is because there could be some reason, but there probably isn't. The only possible reason that I can see would be that BlueZ wants to reserve the right to change the case of the properties at will. I really hope they don't want to do that. -- Tanu