On Sat, 2012-02-25 at 11:03 +0000, Colin Guthrie wrote: > 'Twas brillig, and Arun Raghavan at 25/02/12 04:00 did gyre and gimble: > > On Fri, 2012-02-24 at 21:30 +0000, Colin Guthrie wrote: > >> 'Twas brillig, and Lennart Poettering at 20/02/12 19:08 did gyre and gimble: > >>> Heya, > >>> > >>> It turns out I currently can't build PA on F17, due to some GCC 4.7 ASM > >>> incompatibility in the SBC code: > >>> > >>> CC libbluetooth_sbc_la-sbc_primitives_mmx.lo > >>> modules/bluetooth/sbc/sbc_primitives_mmx.c: In function 'sbc_calc_scalefactors_mmx': > >>> modules/bluetooth/sbc/sbc_primitives_mmx.c:294:4: warning: asm operand 2 > >>> probably doesn't match constraints [enabled by default] > >>> modules/bluetooth/sbc/sbc_primitives_mmx.c:294:4: error: impossible > >>> constraint in 'asm' > >>> make[3]: *** [libbluetooth_sbc_la-sbc_primitives_mmx.lo] Error 1 > >>> > >>> git blame says Siarhei Siamashka wrote this bit. Siarhei, any idea what > >>> is going on here? > >> > >> Looks like: > >> > >> http://git.kernel.org/?p=bluetooth/bluez.git;a=commit;h=03bb9d3426af326642cb4ff280a793cd69a0d844 > >> > >> fixes the issue. > >> > >> "make update-sbc" run and the result pushed to git. > > > > That error does seem to be different from the one posted here, though. > > Yup, I didn't read properly the phrase "pushed a fix for bluez"... Peter > meant he'd pushed a fix to *fedora* for bluez *package*... /me just > assumed the most recent commit in bluez upstream git mentioning sbc was > the one to which he was referring. Silly me. > > Real fix is here: > http://pkgs.fedoraproject.org/gitweb/?p=bluez.git;a=blob;f=sbc_mmx.patch;h=2f00bb6856fb8e313f332d8ed90ca65a3a58de3a;hb=HEAD > > As soon as it goes upstream in bluez we can do make update-sbc again and > push it :)
