Hi Frederic, On Wed, Jul 11, 2012 at 4:20 PM, Dalleau, Frederic <frederic.dalleau at intel.com> wrote: > Hi Mikel, > > On Fri, Jul 6, 2012 at 11:19 AM, Mikel Astiz <mikel.astiz.oss at gmail.com> wrote: >> From: Mikel Astiz <mikel.astiz at bmw-carit.de> >> >> Previous implementation assumes these values are equal, but this doesn't >> necessarily have to be so. > > I have given a try to your patches (on top of upstream + Luiz > patches), and they have been > generally fine, but in one use case something hasn't worked as expected. > > I found the culprit to be : >> - ret = 1; >> + ret = l; > > Is this part of the same patch ? The idea here was to make these functions (hsp_process_push, a2dp_process_render and a2dp_process_push) return the number of bytes, instead of the number of blocks. We could assume that the relation between them is given by the MTU, but this is not guaranteed AFAIK. This information is needed in the thread function, in order to calculate how many blocks (if any) should be sent. Cheers, Mikel
