On Mon, 2012-08-13 at 15:44 +0800, rong deng wrote: > 2012/8/13 Tanu Kaskinen <tanuk at iki.fi>: > > On Fri, 2012-08-03 at 15:12 +0800, Deng Zhengrong wrote: > >> @@ -336,7 +351,10 @@ static void subscribe_callback(pa_core *c, pa_subscription_event_type_t t, uint3 > >> dirty = true; > >> break; > >> } > >> - > >> + if (p_info->max_volume != old_p_info->max_volume) { > >> + dirty = true; > >> + break; > >> + } > >> } else { > >> dirty = true; > >> break; > > > > Later in the function there's this: > > > > if (card->save_profile) > > pa_log_info("Storing profile and port latency offsets for card %s.", card->name); > > else > > pa_log_info("Storing port latency offsets for card %s.", card->name); > > > > That code is now out of date. > > Hi Tanu, > > Thanks for your review, I've updated and sent out another patch. > However, I've checked that the above code is still in pulseaudio's > master repository. Why it's out dated? So I don't add the message "max > volume" into the messages. Sorry for being unclear. I meant that with your patch the messages are outdated, because they don't mention the volume limit. -- Tanu