Hi Chanyeol, On Thu, Aug 2, 2012 at 2:05 AM, Chan-yeol Park <chanyeol.park at gmail.com> wrote: > Hi Luiz > > > On 2012? 08? 01? 22:52, Luiz Augusto von Dentz wrote: >> >> Hi Chanyeol, >> >> On Wed, Aug 1, 2012 at 8:18 AM, <chanyeol.park at samsung.com> wrote: >>> >>> From: Chan-yeol Park <chanyeol.park at samsung.com> >>> >>> These files are remove in the bluez project. >>> In case of definitions in the ipc files >>> we could use defintions in the a2dp-codecs.h >>> --- >>> src/modules/bluetooth/bluetooth-util.c | 101 >>> +++++++++-------- >>> src/modules/bluetooth/ipc.c | 134 >>> ----------------------- >>> src/modules/bluetooth/ipc.h | 117 >>> -------------------- >>> src/modules/bluetooth/module-bluetooth-device.c | 35 +++--- >>> 4 files changed, 66 insertions(+), 321 deletions(-) >>> delete mode 100644 src/modules/bluetooth/ipc.c >>> delete mode 100644 src/modules/bluetooth/ipc.h >>> >>> I though this was part of Mikel's patches, but apparently he forgot about >>> this. >>> >>> Ack. >>> > Yes. > > He still use ipc.h file's definitions. I've just replaced them with > a2dp-codecs.h and remove ipc files. > http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-July/014035.html > > Maybe there are some reason. I left this change for later because I considered it non-trivial, to be checked exhaustively. The patch seems good: I found no problem during testing and even the compiled binary versions seem to be the same (once a few struct members have been restored). So ack from my side. Cheers, Mikel
