On 08/08/2012 03:21 PM, rong deng wrote: > 2012/8/8, David Henningsson <david.henningsson at canonical.com>: >> On 07/17/2012 08:45 AM, Deng Zhengrong wrote: >>> +#### check test framework #### >>> + >>> +PKG_CHECK_MODULES(LIBCHECK, [ check ]) >>> +AC_SUBST(LIBCHECK_CFLAGS) >>> +AC_SUBST(LIBCHECK_LIBS) >>> + >> >> Is it possible to make this build dependency optional? If so, please do, >> because >> 1) if you just want to compile PulseAudio and not the tests, you >> should be able to, and >> 2) I have to go through some administrative work if I have to bring in >> yet another build dependency to PulseAudio. :-/ > > Hi David, > > Thanks for the review, I have a little different opinion: > 1. when we're in the process of development, we should always run the > tests all the time to track any possible regressions. It's not a good > idea to bypass the tests, because that's the value of all these tests, > otherwise we could just delete them all. :) > 2. it's sad to bring in yet another build dependency, but you know > life is not perfect... We've already added e.g. json lib before. > Besides, this check framework is already widely used in other > programs, e.g. gstreamer. and I've checked with several major linux > distribution that this can be easily installed. mostly install check > or check-devel or something similar. One command and it's all set. :) But what about a user of e g Linux From Scratch or other minimalist distros, who just wants to set up and build PulseAudio as quick as possible? Why should (s)he be required to also bring in the check package just for building it? For Ubuntu I've noticed that the "check" package is in main, so it's not as terrible as it was with json-c, but still. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
