On Fri, Aug 03, 2012 at 08:25:18PM +0800, rong deng wrote: > Hi Poljar, > > Sorry for top posting. > > This patch is based on your github's commit. Of course, it doesn't > work yet because not everything is weaved together... However I'd like > to give others a chance to see what i'm doing and whether i'm on the > right track. > Hi. I've changed the variable from maximum_volume to max_volume (for consistency sake). I've gave the patch a glimpse and for now it looks fine to me.