On Wed, 2012-04-25 at 10:45 +0200, Peter Meerwald wrote: > Hello Tanu, > > > --- > > src/modules/echo-cancel/module-echo-cancel.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I am wondering how you came up with these echo-cancel related patches? > are there concrete issues you are fixing, is it code reading/review? > > is there some regression testing in place? the EC module is big and > non-trivial > > what is the situation where this problem triggers? > > I am not complaining about a specific patch you submitted, just concerned > about the testability of the EC stuff We need some automated tests for the canceller implementation itself, but the sink and source bits are really hard to test independently, since they depend on real-time behaviour of the hardware and system. For any non-trivial changes, I usually do manual testing for a bit. -- Arun
