On Thu, 2012-04-12 at 15:45 +0200, David Henningsson wrote: > On 04/12/2012 01:59 PM, Tanu Kaskinen wrote: > > New since v3: > > - Doesn't crash 100% of the time. > > Only 99% of the time? :-) (Sorry, couldn't resist) Possibly :) I initially wrote "100% crash free", but then I though about what evidence I have to support that claim, and I realized that I can only say that Pulseaudio doesn't crash always with these patches. > > - Fixed port proplists in the native protocol's card info. > > - Added pa_proplist_key_valid() to the public API. > > - Changed pa_tagstruct_get_proplist() to allow NULL > > proplist. > > - Added port proplists to the native protocol's sink and > > source info. > > Whether to do that I guess kind of depends on whether we want to > deprecate sink/source ports (and only use card ports). If we do want to > keep them, we should probably also send out subscription notifications > for sink/source when a port's availability changes. Thanks for reminding - I think this has been discussed before. I'm for deprecating the sink and source port info structs (or at least cease further development). Not having the proplists in the sink and source info structs makes "pactl list sinks" implementation much more cumbersome, if we want that command to list the port properties, but I think it's ok to print the port properties only with "pactl list cards". -- Tanu
