2011/9/28 Arun Raghavan <arun.raghavan at collabora.co.uk>: > On Wed, 2011-09-28 at 09:50 +0200, Maarten Bosmans wrote: >> This patch was sent to the list before, but was deemend to riscy pre-1.0. >> So now I'll resend. It does touch de same code as David fixed with 42bcb418aed SSE/MMX: Fix problem with highpitched >> noise on i386, but I leaves his solution intact, so it should be safe. >> >> The problem this patch is trying to solve is that the (pa_reg_x86) is not meaningfull with the "m" modifier. GCC ignores >> this, but clang (correctly) whines about it. > > Do we have an easy way to make sure the problem David fixed continues to > not be there with this patch? There's no regression test for this. I have some tests here locally and will try it. But just reasoning about it tells you that it is safe. David's patch changed the modifier. That modifier is left untouched by my patch. Maarten
