On Mon, 2011-09-05 at 11:43 +0200, Colin Guthrie wrote: > * module-match should require pcre support, not be optional (i.e. it > should behave consistently, and not be build-time feature specific > (Tanu, you may have comments about this? Want to overrule this > recommendation?) No, I don't really have any opinions regarding this. I don't know why we support two regexp libraries. > * PA_SINK_SHARE_VOLUME_WITH_MASTER should not be in the public headers. > Any bright ideas how to handle this seeing as it's a public enum? Introduce a private enum for server side sink flags? That idea sounds so obvious that it probably doesn't fulfill your requirement of being bright, though :) -- Tanu
