Hi, I added a couple blocker bugs to 1.0 after Lennart's comments. Nothing too big really - see the tracking bug: https://bugs.freedesktop.org/show_bug.cgi?id=40193 There are a few other minor things that I will take care of and push later today most likely (didn't seem worth creating a bug. But if anyone else beats me to it these are: * module-match should require pcre support, not be optional (i.e. it should behave consistently, and not be build-time feature specific (Tanu, you may have comments about this? Want to overrule this recommendation?) * The meempool vacuum stuff in the idle module looks at the wrong place - it should be in core where the vacuum-on-no-streams logic is too. And a function "check_meempool_vacuum" is obviously a typo! * PA_SINK_SHARE_VOLUME_WITH_MASTER should not be in the public headers. Any bright ideas how to handle this seeing as it's a public enum? * Generic Lennart comment: the PA_LOG_FD stuff I really don't like. Any ideas on how to make it Lennart-compatible? Perhaps the concept is just one he doesn't like, but as it was developed by some embedded folks (Intel I believe) it's clearly useful to some people. That's all folks. Nothing too crazy and all fixable in a couple days I think :) Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
